chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm - Issue 3046029: [Mac] First pass at final sizing of toolbar items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm

Issue 3046029: [Mac] First pass at final sizing of toolbar items. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: Don't disable unit tests for realz, sorry. Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/nibs/Toolbar.xib ('K') | « chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm ('k') | chrome/browser/cocoa/location_bar/bubble_decoration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm

diff --git a/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm b/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm

index 341058c1880b2abe0d4c92f390aa7fad2ad3586f..29beb38e71947a4ab16d9d8ff1c69f9ad772038d 100644

--- a/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm

+++ b/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm

@@ -427,7 +427,7 @@ TEST_F(AutocompleteTextFieldTest, ClickBorderSelectsAll) {

TEST_F(AutocompleteTextFieldTest, ClickSelectsAll) {

EXPECT_FALSE([field_ currentEditor]);

- const NSPoint point(NSMakePoint(20.0, 5.0));

+ const NSPoint point = NSMakePoint(20.0, NSMidY([field_ bounds]));

NSEvent* downEvent(Event(field_, point, NSLeftMouseDown));

NSEvent* upEvent(Event(field_, point, NSLeftMouseUp));

[NSApp postEvent:upEvent atStart:YES];

@@ -468,7 +468,7 @@ TEST_F(AutocompleteTextFieldTest, ClickDragSelectsText) {

TEST_F(AutocompleteTextFieldTest, DoubleClickSelectsWord) {

EXPECT_FALSE([field_ currentEditor]);

- const NSPoint point(NSMakePoint(20.0, 5.0));

+ const NSPoint point = NSMakePoint(20.0, NSMidY([field_ bounds]));

NSEvent* downEvent(Event(field_, point, NSLeftMouseDown, 1));

NSEvent* upEvent(Event(field_, point, NSLeftMouseUp, 1));

NSEvent* downEvent2(Event(field_, point, NSLeftMouseDown, 2));