Changes gcl upload to print a reminder that it doesn't do a try.

Changes gcl upload to print a reminder that it doesn't do a try.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53537

[sky, 2010-07-22 15:50:23]

This breaks the unit tests because of unexpected calls for the print
message. I'm not sure how to mock that out though. Any hints?

Thanks,

  -Scott

On Thu, Jul 22, 2010 at 8:30 AM,  <sky@chromium.org> wrote:
> Reviewers: Marc-Antoine Ruel,
>
> Description:
> Changes gcl upload to print a reminder that it doesn't do a try.
>
>
>
> Please review this at http://codereview.chromium.org/3046011/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
>
> Affected files:
>  M     gcl.py
>
>
> Index: gcl.py
> ===================================================================
> --- gcl.py      (revision 53338)
> +++ gcl.py      (working copy)
> @@ -804,6 +804,8 @@
>   # consistent.
>   os.chdir(previous_cwd)
>
> +  print "*** Upload does not submit a try; use gcl try to submit a try.
> ***"
> +
>   return 0
>
>
>
>
>

[M-A Ruel, 2010-07-23 19:56:13]

On 2010/07/22 15:50:23, sky wrote:
> This breaks the unit tests because of unexpected calls for the print
> message. I'm not sure how to mock that out though. Any hints?

you need to do a sys.stdout.write("*** Upload does not submit a try; use gcl try
to submit a try. ***") inside the test. You can check-in anyway and fix the
tests later. I won't be able to fix it soon since I'm ooo next week.

lgtm

[sky, 2010-07-23 22:38:10]

On Fri, Jul 23, 2010 at 12:56 PM,  <maruel@chromium.org> wrote:
> On 2010/07/22 15:50:23, sky wrote:
>>
>> This breaks the unit tests because of unexpected calls for the print
>> message. I'm not sure how to mock that out though. Any hints?
>
> you need to do a sys.stdout.write("*** Upload does not submit a try; use gcl
> try
> to submit a try. ***") inside the test. You can check-in anyway and fix the
> tests later. I won't be able to fix it soon since I'm ooo next week.

I landed the change now since I'm also OOO next week. I'll fix the
test when I get back.

  -Scott