Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: gcl.py

Issue 3046011: Changes gcl upload to print a reminder that it doesn't do a try. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """\ 6 """\
7 Wrapper script around Rietveld's upload.py that simplifies working with groups 7 Wrapper script around Rietveld's upload.py that simplifies working with groups
8 of files. 8 of files.
9 """ 9 """
10 10
(...skipping 786 matching lines...) Expand 10 before | Expand all | Expand 10 after
797 os.remove(desc_file) 797 os.remove(desc_file)
798 798
799 # Do background work on Rietveld to lint the file so that the results are 799 # Do background work on Rietveld to lint the file so that the results are
800 # ready when the issue is viewed. 800 # ready when the issue is viewed.
801 SendToRietveld("/lint/issue%s_%s" % (issue, patchset), timeout=0.5) 801 SendToRietveld("/lint/issue%s_%s" % (issue, patchset), timeout=0.5)
802 802
803 # Move back before considering try, so GetCodeReviewSettings is 803 # Move back before considering try, so GetCodeReviewSettings is
804 # consistent. 804 # consistent.
805 os.chdir(previous_cwd) 805 os.chdir(previous_cwd)
806 806
807 print "*** Upload does not submit a try; use gcl try to submit a try. ***"
808
807 return 0 809 return 0
808 810
809 811
810 @need_change 812 @need_change
811 def CMDpresubmit(change_info): 813 def CMDpresubmit(change_info):
812 """Runs presubmit checks on the change. 814 """Runs presubmit checks on the change.
813 815
814 The actual presubmit code is implemented in presubmit_support.py and looks 816 The actual presubmit code is implemented in presubmit_support.py and looks
815 for PRESUBMIT.py files.""" 817 for PRESUBMIT.py files."""
816 if not change_info.GetFiles(): 818 if not change_info.GetFiles():
(...skipping 482 matching lines...) Expand 10 before | Expand all | Expand 10 after
1299 if command: 1301 if command:
1300 return command(argv[1:]) 1302 return command(argv[1:])
1301 # Unknown command, try to pass that to svn 1303 # Unknown command, try to pass that to svn
1302 return CMDpassthru(argv) 1304 return CMDpassthru(argv)
1303 except gclient_utils.Error, e: 1305 except gclient_utils.Error, e:
1304 print('Got an exception') 1306 print('Got an exception')
1305 print(str(e)) 1307 print(str(e))
1306 1308
1307 if __name__ == "__main__": 1309 if __name__ == "__main__":
1308 sys.exit(main(sys.argv[1:])) 1310 sys.exit(main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698