Add an #ifndef to modp_b64_data.h to avoid a typedef conflict that certain...

Add an #if to modp_b64_data.h to avoid a typedef conflict that certain
finicky compilers (in particular, nacl-g++) complain about.

Contributed by mdsteele@google.com

BUG=none
TEST=Try to compile modp_b64 with nacl-g++

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55137

[Mark Mentovai, 2010-08-04 19:31:17]

http://codereview.chromium.org/3044045/diff/1/2
File third_party/modp_b64/README.chromium (right):

http://codereview.chromium.org/3044045/diff/1/2#newcode15
third_party/modp_b64/README.chromium:15: include "base/basictypes.h" and perform
the required typedefs for
You don’t really perform typedefs, you provide them.

http://codereview.chromium.org/3044045/diff/1/3
File third_party/modp_b64/modp_b64_data.h (right):

http://codereview.chromium.org/3044045/diff/1/3#newcode1
third_party/modp_b64/modp_b64_data.h:1: #ifndef COMPILER_MSVC
You can’t do this without first #including "build/build_config.h".

[Matthew Steele, 2010-08-04 19:37:11]

Oops, thanks for the catches.

http://codereview.chromium.org/3044045/diff/1/2
File third_party/modp_b64/README.chromium (right):

http://codereview.chromium.org/3044045/diff/1/2#newcode15
third_party/modp_b64/README.chromium:15: include "base/basictypes.h" and perform
the required typedefs for
On 2010/08/04 19:31:22, Mark Mentovai wrote:
> You don’t really perform typedefs, you provide them.

Changed.

http://codereview.chromium.org/3044045/diff/1/3
File third_party/modp_b64/modp_b64_data.h (right):

http://codereview.chromium.org/3044045/diff/1/3#newcode1
third_party/modp_b64/modp_b64_data.h:1: #ifndef COMPILER_MSVC
On 2010/08/04 19:31:22, Mark Mentovai wrote:
> You can’t do this without first #including "build/build_config.h".

Fixed.

[Mark Mentovai, 2010-08-04 21:23:20]

LGTM

http://codereview.chromium.org/3044045/diff/6001/7002
File third_party/modp_b64/modp_b64_data.h (right):

http://codereview.chromium.org/3044045/diff/6001/7002#newcode2
third_party/modp_b64/modp_b64_data.h:2: #ifndef COMPILER_MSVC
Chromium style is #if !defined(COMPILER_MSVC)

[Matthew Steele, 2010-08-05 14:13:10]

Thanks for the review!  I do not have committer status; could you please submit
this patch for me?

http://codereview.chromium.org/3044045/diff/6001/7002
File third_party/modp_b64/modp_b64_data.h (right):

http://codereview.chromium.org/3044045/diff/6001/7002#newcode2
third_party/modp_b64/modp_b64_data.h:2: #ifndef COMPILER_MSVC
On 2010/08/04 21:23:20, Mark Mentovai wrote:
> Chromium style is #if !defined(COMPILER_MSVC)

Done.

[Mark Mentovai, 2010-08-05 21:54:25]

Committed r55137.