Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/modp_b64/README.chromium

Issue 3044045: Add an #ifndef to modp_b64_data.h to avoid a typedef conflict that certain... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/modp_b64/modp_b64_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/modp_b64/README.chromium
===================================================================
--- third_party/modp_b64/README.chromium (revision 54936)
+++ third_party/modp_b64/README.chromium (working copy)
@@ -8,7 +8,9 @@
modp_b64.cc to force it to be compiled as C++ so that the inclusion of
basictypes.h could be possible.
-The file modp_b64_data.h was generated by modp_b64_gen.c (under Linux), which
-is not included in this directory. The resulting header was modified to remove
-the "#include <stdint.h>" since that header file does not exist under VC8. The
-required typedefs for uint8_t and uint32_t were defined in its place.
+The file modp_b64_data.h was generated by modp_b64_gen.c (under Linux),
+which is not included in this directory. The resulting header was
+modified to not include <stdint.h> when COMPILER_MSVC is defined (since
+that header file does not exist under VC8), but instead in that case to
+include "base/basictypes.h" and provide the required typedefs for
+uint8_t and uint32_t using uint8 and uint32.
« no previous file with comments | « no previous file | third_party/modp_b64/modp_b64_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698