Issue 3044007: Set url fetch test timeout back to old values. Increase UI test command timeo...

Issue 3044007: Set url fetch test timeout back to old values. Increase UI test command timeo... (Closed)

Created:
10 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, Paweł Hajdan Jr., Miranda Callahan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Set url fetch test timeout back to old values. Increase UI test command timeout a bit to accommodate failng tests. BUG=none TEST=Vista perf goes green; xp test dbg 2 goes green. TBR=phajdan.jr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52824

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -4 lines)			Patch
M	chrome/test/pyautolib/pyauto.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/url_fetch_test/url_fetch_test.cc	View	1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/20450/steps/ui_tests/logs/stdio [ RUN ] NewTabUITest.UpdateUserPrefsVersion [ OK ] NewTabUITest.UpdateUserPrefsVersion (20719 ms) http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(2)/builds/20500/steps/ui_tests/logs/stdio [ RUN ] ...

10 years, 5 months ago (2010-07-17 10:52:54 UTC) #1

Paweł Hajdan Jr.

Sorry about late review. One comment. http://codereview.chromium.org/3044007/diff/5001/6003 File chrome/test/url_fetch_test/url_fetch_test.cc (right): http://codereview.chromium.org/3044007/diff/5001/6003#newcode48 chrome/test/url_fetch_test/url_fetch_test.cc:48: set_action_timeout_ms(std::max(60000, action_timeout_ms())); Please ...

10 years, 5 months ago (2010-07-19 18:29:09 UTC) #2

Lei Zhang

10 years, 5 months ago (2010-07-19 18:49:01 UTC) #3

http://codereview.chromium.org/3044007/diff/5001/6003
File chrome/test/url_fetch_test/url_fetch_test.cc (right):

http://codereview.chromium.org/3044007/diff/5001/6003#newcode48
chrome/test/url_fetch_test/url_fetch_test.cc:48:
set_action_timeout_ms(std::max(60000, action_timeout_ms()));
On 2010/07/19 18:29:10, Paweł Hajdan Jr. wrote:
> Please do it via a command-line flag, not in the code. Could you do a
follow-up
> CL?

Sure, it was 2 AM and I needed to plug the hole.

Expand Messages | Collapse Messages