Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: chrome/test/url_fetch_test/url_fetch_test.cc

Issue 3044007: Set url fetch test timeout back to old values. Increase UI test command timeo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: cleanup Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/ui/ui_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/file_path.h" 6 #include "base/file_path.h"
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 24 matching lines...) Expand all
35 #if defined(OS_WIN) 35 #if defined(OS_WIN)
36 dir = dir.AppendASCII("chrome"); 36 dir = dir.AppendASCII("chrome");
37 #elif defined(OS_LINUX) 37 #elif defined(OS_LINUX)
38 dir = dir.AppendASCII("chrome_linux"); 38 dir = dir.AppendASCII("chrome_linux");
39 #elif defined(OS_MACOSX) 39 #elif defined(OS_MACOSX)
40 dir = dir.AppendASCII("chrome_mac"); 40 dir = dir.AppendASCII("chrome_mac");
41 #endif 41 #endif
42 browser_directory_ = dir; 42 browser_directory_ = dir;
43 } 43 }
44 UITest::SetUp(); 44 UITest::SetUp();
45
46 // We've shortened the default timeouts, but dom_perf on Vista needs longer
47 // timeouts. Setting timeouts to the previous values before r52666.
48 set_action_timeout_ms(std::max(60000, action_timeout_ms()));
Paweł Hajdan Jr. 2010/07/19 18:29:10 Please do it via a command-line flag, not in the c
Lei Zhang 2010/07/19 18:49:01 Sure, it was 2 AM and I needed to plug the hole.
45 } 49 }
46 50
47 void RunTest(const GURL& url, const char* wait_cookie_name, 51 void RunTest(const GURL& url, const char* wait_cookie_name,
48 const char* wait_cookie_value, const wchar_t* var_to_fetch, 52 const char* wait_cookie_value, const wchar_t* var_to_fetch,
49 UrlFetchTestResult* result) { 53 UrlFetchTestResult* result) {
50 scoped_refptr<TabProxy> tab(GetActiveTab()); 54 scoped_refptr<TabProxy> tab(GetActiveTab());
51 ASSERT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS, tab->NavigateToURL(url)); 55 ASSERT_EQ(AUTOMATION_MSG_NAVIGATION_SUCCESS, tab->NavigateToURL(url));
52 56
53 if (wait_cookie_name) { 57 if (wait_cookie_name) {
54 if (wait_cookie_value) { 58 if (wait_cookie_value) {
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 139
136 // Write out the JS Variable if requested 140 // Write out the JS Variable if requested
137 FilePath jsvar_output_path = cmd_line->GetSwitchValuePath("jsvar_output"); 141 FilePath jsvar_output_path = cmd_line->GetSwitchValuePath("jsvar_output");
138 if (jsvar_output_path.value().size() > 0) { 142 if (jsvar_output_path.value().size() > 0) {
139 ASSERT_TRUE(WriteValueToFile(result.javascript_variable, 143 ASSERT_TRUE(WriteValueToFile(result.javascript_variable,
140 jsvar_output_path)); 144 jsvar_output_path));
141 } 145 }
142 } 146 }
143 147
144 } // namespace 148 } // namespace
OLDNEW
« no previous file with comments | « chrome/test/ui/ui_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698