Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 3043048: Clean up download code: (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., Paul Godavari, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Clean up download code: - move filename generation parts and related code out of DownloadManager download_util is not the best place for it, but it's better than DownloadManager which we're trying to minimize - clean up posting tasks to different threads. There's no need to create separate methods for that, it was cluttering the file needlessly - other minor cleanups, like using static_cast instead of C-style cast TEST=unit_tests, browser_tests, ui_tests BUG=48913 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+929 lines, -950 lines) Patch
M chrome/browser/cocoa/web_drag_source.mm View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/download/download_exe.cc View 2 chunks +50 lines, -2 lines 0 comments Download
M chrome/browser/download/download_item.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/download/download_manager.h View 6 chunks +0 lines, -46 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 15 chunks +16 lines, -289 lines 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 3 chunks +0 lines, -589 lines 0 comments Download
M chrome/browser/download/download_util.h View 4 chunks +34 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.cc View 4 chunks +204 lines, -0 lines 0 comments Download
A chrome/browser/download/download_util_unittest.cc View 1 chunk +588 lines, -0 lines 0 comments Download
M chrome/browser/download/save_package.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/gtk/tab_contents_drag_source.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_drag_win.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
10 years, 4 months ago (2010-08-03 00:11:17 UTC) #1
ahendrickson
LGTM.
10 years, 4 months ago (2010-08-03 17:20:51 UTC) #2
Paweł Hajdan Jr.
10 years, 4 months ago (2010-08-03 21:07:17 UTC) #3
Darin: ping.

Powered by Google App Engine
This is Rietveld 408576698