Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3165)

Unified Diff: chrome/browser/download/download_util.h

Issue 3043048: Clean up download code: (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | chrome/browser/download/download_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_util.h
diff --git a/chrome/browser/download/download_util.h b/chrome/browser/download/download_util.h
index dcd24416e11b481dd43fdf9d3bb9e00c7a9b900f..aa7832ca25f57d7b8007234494e7a3aa10afef95 100644
--- a/chrome/browser/download/download_util.h
+++ b/chrome/browser/download/download_util.h
@@ -12,6 +12,7 @@
#include <string>
#include "base/basictypes.h"
+#include "base/file_path.h"
#include "gfx/native_widget_types.h"
#if defined(TOOLKIT_VIEWS)
@@ -25,12 +26,14 @@ class Canvas;
class BaseDownloadItemModel;
class DictionaryValue;
class DownloadItem;
-class FilePath;
+class DownloadManager;
class GURL;
+class Profile;
class ResourceDispatcherHost;
class SkBitmap;
class URLRequestContextGetter;
+struct DownloadCreateInfo;
struct DownloadSaveInfo;
namespace download_util {
@@ -47,6 +50,32 @@ bool CreateTemporaryFileForDownload(FilePath* path);
// Return true if the |download_path| is dangerous path.
bool DownloadPathIsDangerous(const FilePath& download_path);
+// Create an extension based on the file name and mime type.
+void GenerateExtension(const FilePath& file_name,
+ const std::string& mime_type,
+ FilePath::StringType* generated_extension);
+
+// Create a file name based on the response from the server.
+void GenerateFileNameFromInfo(DownloadCreateInfo* info,
+ FilePath* generated_name);
+
+// Create a file name based on the response from the server.
+void GenerateFileName(const GURL& url,
+ const std::string& content_disposition,
+ const std::string& referrer_charset,
+ const std::string& mime_type,
+ FilePath* generated_name);
+
+// Used to make sure we have a safe file extension and filename for a
+// download. |file_name| can either be just the file name or it can be a
+// full path to a file.
+void GenerateSafeFileName(const std::string& mime_type, FilePath* file_name);
+
+// Opens downloaded Chrome extension file (*.crx).
+void OpenChromeExtension(Profile* profile,
+ DownloadManager* download_manager,
+ const DownloadItem& download_item);
+
// Download progress animations ------------------------------------------------
// Arc sweep angle for use with downloads of unknown size
@@ -125,7 +154,10 @@ void DragDownload(const DownloadItem* download,
// Executable file support -----------------------------------------------------
// Determine if the specified extension is an executable extension.
-bool IsExecutableExtension(const std::string& extension);
+bool IsExecutableExtension(const FilePath::StringType& extension);
+
+// Tests if we think the server means for this mime_type to be executable.
+bool IsExecutableMimeType(const std::string& mime_type);
// Helpers ---------------------------------------------------------------------
« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | chrome/browser/download/download_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698