Issue 3041024: Set --free-is-write TSan flag default value to "no"....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3041024: Set --free-is-write TSan flag default value to "no".... (Closed)

Created:
10 years, 5 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Set --free-is-write TSan flag default value to "no". As of r2200 (in Chromium SVN now), the default value is "no". As of r2344 (planned to check-in soon), the default value is "yes" but some false positive reports are not yet eliminated for this mode. BUG=http://code.google.com/p/data-race-test/issues/detail?id=40 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53780

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	tools/valgrind/valgrind_test.py	View		2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 5 months ago (2010-07-27 13:09:45 UTC) #2

On 2010/07/27 13:07:59, Timur Iskhodzhanov wrote:
> 

LGTM

Expand Messages | Collapse Messages