Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/valgrind/valgrind_test.py

Issue 3041024: Set --free-is-write TSan flag default value to "no".... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/valgrind_test.py
===================================================================
--- tools/valgrind/valgrind_test.py (revision 53612)
+++ tools/valgrind/valgrind_test.py (working copy)
@@ -587,6 +587,13 @@
parser.add_option("", "--announce-threads", default="yes",
dest="announce_threads",
help="Show the the stack traces of thread creation")
+ parser.add_option("", "--free-is-write", default="no",
+ dest="free_is_write",
+ help="Treat free()/operator delete as memory write. "
+ "This helps finding more data races, but (currently) "
+ "this may give false positive reports on std::string "
+ "internals, see http://code.google.com/p/data-race-test"
+ "/issues/detail?id=40")
def EvalBoolFlag(self, flag_value):
if (flag_value in ["1", "true", "yes"]):
@@ -622,6 +629,12 @@
if self.EvalBoolFlag(self._options.announce_threads):
ret += ["--announce-threads"]
+ if self.EvalBoolFlag(self._options.free_is_write):
+ ret += ["--free-is-write=yes"]
+ else:
+ ret += ["--free-is-write=no"]
+
+
# --show-pc flag is needed for parsing the error logs on Darwin.
if platform_suffix == 'mac':
ret += ["--show-pc=yes"]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698