Issue 304003: Add more string16 variants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304003: Add more string16 variants. (Closed)

Created:
11 years, 2 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, brettw

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add more string16 variants. R=brettw BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29440

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	base/string_util.h	View		3 chunks	+9 lines, -0 lines	0 comments	Download
	M	base/string_util.cc	View	1	4 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lg http://codereview.chromium.org/304003/diff/1/3 File base/string_util.cc (right): http://codereview.chromium.org/304003/diff/1/3#newcode1360 Line 1360: string16 JoinString(const std::vector<string16 & parts, char sep) ...

11 years, 2 months ago (2009-10-19 18:47:57 UTC) #2

darin (slow to review)

11 years, 2 months ago (2009-10-19 19:20:05 UTC) #4

On Mon, Oct 19, 2009 at 11:47 AM, <mark@chromium.org> wrote:

> lg
>
>
> http://codereview.chromium.org/304003/diff/1/3
> File base/string_util.cc (right):
>
> http://codereview.chromium.org/304003/diff/1/3#newcode1360
> Line 1360: string16 JoinString(const std::vector<string16 & parts, char
> sep) {
> nit: no space before the &.


in fact, it just needed a ">" in that space ;-)



>
>
> http://codereview.chromium.org/304003
>

Expand Messages | Collapse Messages

Issue 304003: Add more string16 variants. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages