Issue 3039028: Make HttpAuthController not reference counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3039028: Make HttpAuthController not reference counted. (Closed)

Created:
10 years, 5 months ago by vandebo (ex-Chrome)

Modified:
8 years, 11 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Make HttpAuthController not reference counted. This forces the HttpAuthController to live with the socket, making the socket specific state work out. BUG=49493 TEST=unit tests

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -77 lines)			Patch
M	net/http/http_auth_controller.h	View	5 chunks	+15 lines, -8 lines	0 comments	Download
M	net/http/http_auth_controller.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	net/http/http_network_transaction.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/http/http_network_transaction.cc	View	3 chunks	+14 lines, -8 lines	0 comments	Download
M	net/http/http_proxy_client_socket.h	View	4 chunks	+15 lines, -7 lines	0 comments	Download
M	net/http/http_proxy_client_socket.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	net/http/http_proxy_client_socket_pool.h	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	net/http/http_proxy_client_socket_pool.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/http/http_proxy_client_socket_pool_unittest.cc	View	7 chunks	+22 lines, -13 lines	0 comments	Download
M	net/socket/socket_test_util.h	View	3 chunks	+16 lines, -4 lines	0 comments	Download
M	net/socket/socket_test_util.cc	View	4 chunks	+23 lines, -4 lines	0 comments	Download
M	net/socket/ssl_client_socket_pool.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	net/socket/ssl_client_socket_pool_unittest.cc	View	8 chunks	+28 lines, -19 lines	0 comments	Download