Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: samples/o3d-webgl-samples/texturesamplers.html

Issue 3038014: o3d-webgl: Adjusting Sampler to throw an error if client attempts to use BORD... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « samples/o3d-webgl-samples/shadow-map.html ('k') | samples/o3d-webgl/sampler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/o3d-webgl-samples/texturesamplers.html
===================================================================
--- samples/o3d-webgl-samples/texturesamplers.html (revision 53812)
+++ samples/o3d-webgl-samples/texturesamplers.html (working copy)
@@ -185,10 +185,10 @@
samplers[1].minFilter = g_o3d.Sampler.ANISOTROPIC;
samplers[1].maxAnisotropy = 4;
- // Uses BORDER addressing mode with a red border.
- samplers[2].addressModeU = g_o3d.Sampler.BORDER;
- samplers[2].addressModeV = g_o3d.Sampler.BORDER;
- samplers[2].borderColor = [1, 0, 0, 1];
+ // Note: BORDER addressing is not supported in WebGL.
+ //samplers[2].addressModeU = g_o3d.Sampler.BORDER;
+ //samplers[2].addressModeV = g_o3d.Sampler.BORDER;
+ //samplers[2].borderColor = [1, 0, 0, 1];
// Uses POINT sampling for minification.
samplers[3].addressModeU = g_o3d.Sampler.WRAP;
« no previous file with comments | « samples/o3d-webgl-samples/shadow-map.html ('k') | samples/o3d-webgl/sampler.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698