Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: samples/o3d-webgl-samples/shadow-map.html

Issue 3038014: o3d-webgl: Adjusting Sampler to throw an error if client attempts to use BORD... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | samples/o3d-webgl-samples/texturesamplers.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/o3d-webgl-samples/shadow-map.html
===================================================================
--- samples/o3d-webgl-samples/shadow-map.html (revision 53812)
+++ samples/o3d-webgl-samples/shadow-map.html (working copy)
@@ -260,9 +260,11 @@
g_shadowSampler.minFilter = g_o3d.Sampler.POINT;
g_shadowSampler.magFilter = g_o3d.Sampler.POINT;
g_shadowSampler.mipFilter = g_o3d.Sampler.POINT;
- g_shadowSampler.addressModeU = g_o3d.Sampler.BORDER;
- g_shadowSampler.addressModeV = g_o3d.Sampler.BORDER;
- g_shadowSampler.borderColor = [1, 1, 1, 1];
+ // Note: The o3d-plugin used BORDER as address mode, but that is not available
+ // in WebGL so use WRAP instead.
+ g_shadowSampler.addressModeU = g_o3d.Sampler.WRAP;
+ g_shadowSampler.addressModeV = g_o3d.Sampler.WRAP;
+ //g_shadowSampler.borderColor = [1, 1, 1, 1];
}
« no previous file with comments | « no previous file | samples/o3d-webgl-samples/texturesamplers.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698