Issue 3036026: Adding a retry and logging utility + appengine backend....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3036026: Adding a retry and logging utility + appengine backend.... (Closed)

Created:
10 years, 4 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
nsylvain

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/tools/

Visibility:
Public.

Description

Adding a retry and logging utility + appengine backend. This will be used to monitor and diagnose gsutil failures for nacl + chromeos. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54172

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 3

Patch Set 5 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+272 lines, -0 lines)			Patch
A	command_wrapper/app.yaml	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	command_wrapper/bin/command_wrapper.py	View	1 2 3	1 chunk	+94 lines, -0 lines	0 comments	Download
A	command_wrapper/command_wrapper_web.py	View	1 2	1 chunk	+90 lines, -0 lines	0 comments	Download
A	command_wrapper/index.yaml	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	command_wrapper/viewer.html	View	1 2 3 4	1 chunk	+77 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nsylvain

lgtm with | escape everywhere http://codereview.chromium.org/3036026/diff/7001/8002 File command_wrapper/bin/command_wrapper.py (right): http://codereview.chromium.org/3036026/diff/7001/8002#newcode55 command_wrapper/bin/command_wrapper.py:55: f = urllib.urlopen(options.logurl, params) ...

10 years, 4 months ago (2010-07-29 20:07:16 UTC) #2

bradn

10 years, 4 months ago (2010-07-29 20:12:58 UTC) #3

Done

http://codereview.chromium.org/3036026/diff/7001/8002
File command_wrapper/bin/command_wrapper.py (right):

http://codereview.chromium.org/3036026/diff/7001/8002#newcode55
command_wrapper/bin/command_wrapper.py:55: f = urllib.urlopen(options.logurl,
params)
On 2010/07/29 20:07:16, nsylvain wrote:
> are the params POST by default?
yes

Expand Messages | Collapse Messages