Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 3035062: Revert 55400 - Cleanup in base. This moves the implementation (and a bunch of... (Closed)

Created:
10 years, 4 months ago by nsylvain
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, fbarchard, Alpha Left Google, Sergey Ulanov, John Grabowski, amit, brettw-cc_chromium.org, jam, dmac, darin-cc_chromium.org, awong, garykac, Paweł Hajdan Jr., pam+watch_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Revert 55400 - Cleanup in base. This moves the implementation (and a bunch of header file dependencies) from the multiprocess test and the test_suite headers to .cc files. Moves multiprocess_test to the test directory, and all of this stuff to the existing base_test_support project. I also used the base namespace. Previously other projects included this functionality just by #include because it was all inline, so I had to add dependencies on base_test_support in a few places. Moves and renames the command line switch this was using to base_switches. Move the base switch for process type to chrome switches. TEST=none BUG=none Review URL: http://codereview.chromium.org/3026055 TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -618 lines) Patch
M app/app.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M app/test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
M base/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M base/base.gyp View 3 chunks +2 lines, -9 lines 0 comments Download
M base/base_switches.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/base_switches.cc View 2 chunks +13 lines, -13 lines 0 comments Download
A + base/multiprocess_test.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M base/process_util_unittest.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M base/shared_memory_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M base/stats_table_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
D base/test/multiprocess_test.h View 1 chunk +0 lines, -86 lines 0 comments Download
D base/test/multiprocess_test.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M base/test/perf_test_suite.h View 2 chunks +33 lines, -11 lines 0 comments Download
D base/test/perf_test_suite.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M base/test/run_all_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_suite.h View 2 chunks +208 lines, -35 lines 0 comments Download
D base/test/test_suite.cc View 1 chunk +0 lines, -244 lines 0 comments Download
M chrome/app/breakpad_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_installer.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/process_watcher_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/sandbox_mac_unittest_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/common/sandbox_mac_unittest_helper.mm View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/renderer/renderer_main_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/mini_installer_test/run_all_unittests.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/perf/perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/test_launcher/out_of_proc_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/test_launcher/test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/unit/chrome_test_suite.h View 5 chunks +4 lines, -7 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 3 chunks +1 line, -4 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/perf/run_all.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M courgette/courgette.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M courgette/encoded_program_fuzz_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M courgette/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M gfx/gfx.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gfx/test_suite.h View 2 chunks +1 line, -2 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_tests.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/jingle.gyp View 2 chunks +1 line, -1 line 0 comments Download
M media/base/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/ffmpeg/ffmpeg_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M media/omx/run_all_unittests.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/base/net_test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/run_all_unittests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M printing/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
nsylvain
10 years, 4 months ago (2010-08-09 17:32:20 UTC) #1
brettw
10 years, 4 months ago (2010-08-09 17:52:19 UTC) #2
OK

On Mon, Aug 9, 2010 at 10:32 AM,  <nsylvain@google.com> wrote:
> Reviewers: brettw,
>
> Description:
> Revert 55400 - Cleanup in base. This moves the implementation (and a bunch
> of
> header file
> dependencies) from the multiprocess test and the test_suite headers to .cc
> files. Moves multiprocess_test to the test directory, and all of this stuff
> to
> the existing base_test_support project. I also used the base namespace.
>
> Previously other projects included this functionality just by #include
> because
> it was all inline, so I had to add dependencies on base_test_support in a
> few
> places.
>
> Moves and renames the command line switch this was using to base_switches.
> Move
> the base switch for process type to chrome switches.
>
> TEST=none
> BUG=none
> Review URL: http://codereview.chromium.org/3026055
>
> TBR=brettw@chromium.org
>
> Please review this at http://codereview.chromium.org/3035062/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     app/app.gyp
>  M     app/test_suite.h
>  M     base/DEPS
>  M     base/base.gyp
>  M     base/base_switches.h
>  M     base/base_switches.cc
>  A  +  base/multiprocess_test.h
>  M     base/process_util_unittest.cc
>  M     base/shared_memory_unittest.cc
>  M     base/stats_table_unittest.cc
>  D     base/test/multiprocess_test.h
>  D     base/test/multiprocess_test.cc
>  M     base/test/perf_test_suite.h
>  D     base/test/perf_test_suite.cc
>  M     base/test/run_all_perftests.cc
>  M     base/test/run_all_unittests.cc
>  M     base/test/test_suite.h
>  D     base/test/test_suite.cc
>  M     chrome/app/breakpad_win.cc
>  M     chrome/chrome_installer.gypi
>  M     chrome/common/chrome_switches.h
>  M     chrome/common/chrome_switches.cc
>  M     chrome/common/process_watcher_unittest.cc
>  M     chrome/common/sandbox_mac_unittest_helper.h
>  MM    chrome/common/sandbox_mac_unittest_helper.mm
>  M     chrome/renderer/renderer_main_unittest.cc
>  M     chrome/test/mini_installer_test/run_all_unittests.cc
>  M     chrome/test/perf/perftests.cc
>  M     chrome/test/test_launcher/out_of_proc_test_runner.cc
>  M     chrome/test/test_launcher/test_runner.cc
>  M     chrome/test/unit/chrome_test_suite.h
>  M     chrome_frame/chrome_frame.gyp
>  M     chrome_frame/test/net/fake_external_tab.cc
>  M     chrome_frame/test/perf/run_all.cc
>  M     courgette/courgette.gyp
>  M     courgette/encoded_program_fuzz_unittest.cc
>  M     courgette/run_all_unittests.cc
>  M     gfx/gfx.gyp
>  M     gfx/test_suite.h
>  M     ipc/ipc.gyp
>  M     ipc/ipc_send_fds_test.cc
>  M     ipc/ipc_tests.h
>  M     ipc/ipc_tests.cc
>  M     jingle/jingle.gyp
>  M     media/base/run_all_unittests.cc
>  M     media/ffmpeg/ffmpeg_unittest.cc
>  M     media/media.gyp
>  M     media/omx/run_all_unittests.cc
>  M     net/base/net_test_suite.h
>  M     net/base/run_all_unittests.cc
>  M     net/net.gyp
>  M     printing/printing.gyp
>  M     printing/run_all_unittests.cc
>  M     remoting/remoting.gyp
>  M     remoting/run_all_unittests.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698