Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 3026055: Cleanup in base. This moves the implementation (and a bunch of header file... (Closed)

Created:
10 years, 4 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, fbarchard, Alpha Left Google, John Grabowski, amit, brettw-cc_chromium.org, jam, darin-cc_chromium.org, awong, Paweł Hajdan Jr., pam+watch_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Cleanup in base. This moves the implementation (and a bunch of header file dependencies) from the multiprocess test and the test_suite headers to .cc files. Moves multiprocess_test to the test directory, and all of this stuff to the existing base_test_support project. I also used the base namespace. Previously other projects included this functionality just by #include because it was all inline, so I had to add dependencies on base_test_support in a few places. Moves and renames the command line switch this was using to base_switches. Move the base switch for process type to chrome switches. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55400

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -692 lines) Patch
M base/base.gyp View 3 chunks +12 lines, -1 line 1 comment Download
M base/base_switches.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/base_switches.cc View 2 chunks +13 lines, -13 lines 0 comments Download
D base/multiprocess_test.h View 1 chunk +0 lines, -121 lines 0 comments Download
M base/process_util_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M base/shared_memory_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M base/stats_table_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A + base/test/multiprocess_test.h View 3 chunks +28 lines, -63 lines 0 comments Download
A base/test/multiprocess_test.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M base/test/perf_test_suite.h View 2 chunks +11 lines, -33 lines 0 comments Download
A + base/test/perf_test_suite.cc View 1 chunk +28 lines, -31 lines 0 comments Download
M base/test/run_all_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_suite.h View 2 chunks +28 lines, -209 lines 0 comments Download
A + base/test/test_suite.cc View 4 chunks +159 lines, -177 lines 1 comment Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/process_watcher_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/sandbox_mac_unittest_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/common/sandbox_mac_unittest_helper.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/renderer/renderer_main_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/perf/perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/unit/chrome_test_suite.h View 5 chunks +7 lines, -4 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_tests.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
10 years, 4 months ago (2010-08-05 22:09:50 UTC) #1
Mark Mentovai
10 years, 4 months ago (2010-08-05 22:23:25 UTC) #2
LGTM

http://codereview.chromium.org/3026055/diff/1/2
File base/base.gyp (right):

http://codereview.chromium.org/3026055/diff/1/2#newcode58
base/base.gyp:58: 'test/multiprocess_test.cc',
multiprocss_test.{cc|h} and test_suite.{cc|h} shouldn’t be needed in this target
(base_unittests) now that it depends on test_support_base.

http://codereview.chromium.org/3026055/diff/1/15
File base/test/test_suite.cc (right):

http://codereview.chromium.org/3026055/diff/1/15#newcode61
base/test/test_suite.cc:61: << "Probably the OS #ifdefs don't include all of the
necessary "
I guess the \n is there to keep things from going past 80 columns? The second
sentence does go beyond 80, though.

Powered by Google App Engine
This is Rietveld 408576698