Issue 3035007: Switch OmahaEvent's error_code to ActionExitCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3035007: Switch OmahaEvent's error_code to ActionExitCode. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Switch OmahaEvent's error_code to ActionExitCode. Also, emit the errorcode attribute only for non-success events. Added explicit unit tests for OmahaEvent. BUG=560 TEST=unit tests, gmerged on device, forced update, looked at logs.

Patch Set 1 #

Patch Set 2 : explicit single argument ctor #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -20 lines)			Patch
M	omaha_request_action.h	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
M	omaha_request_action.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	omaha_request_action_unittest.cc	View		5 chunks	+82 lines, -5 lines	0 comments	Download
M	update_attempter.cc	View		2 chunks	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages