Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: omaha_request_action.h

Issue 3035007: Switch OmahaEvent's error_code to ActionExitCode. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: explicit single argument ctor Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | omaha_request_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: omaha_request_action.h
diff --git a/omaha_request_action.h b/omaha_request_action.h
index 5564e737e56629600160a9a9e03cb15b7fd7441c..b487a3bc3f1be6e4c95b3880acc521e7bc17236d 100644
--- a/omaha_request_action.h
+++ b/omaha_request_action.h
@@ -67,15 +67,19 @@ struct OmahaEvent {
OmahaEvent()
: type(kTypeUnknown),
result(kResultError),
- error_code(0) {}
- OmahaEvent(Type in_type, Result in_result, int in_error_code)
+ error_code(kActionCodeError) {}
+ explicit OmahaEvent(Type in_type)
+ : type(in_type),
+ result(kResultSuccess),
+ error_code(kActionCodeSuccess) {}
+ OmahaEvent(Type in_type, Result in_result, ActionExitCode in_error_code)
: type(in_type),
result(in_result),
error_code(in_error_code) {}
Type type;
Result result;
- int error_code;
+ ActionExitCode error_code;
};
class NoneType;
« no previous file with comments | « no previous file | omaha_request_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698