Add connection details to the page info dialog.

Add SSL details to the page info dialog.

BUG=27507
TEST=Navigate to https://encrypted.google.com and click the green padlock. Verify that the details presented are reasonable.

[agl, 2010-07-15 20:26:10]

This is the final part of the series: just the UI.

It might be nice to get this in before the M6 cut-off, but it's not important.

[wtc, 2010-07-16 20:07:10]

LGTM, with concerns on some of the changes, especially the
unnecessary "encrypted" to "secure" changes to three existing
messages.

http://codereview.chromium.org/3033001/diff/4001/5001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/3033001/diff/4001/5001#newcode5193
chrome/app/generated_resources.grd:5193: Your connection to <ph
name="DOMAIN">$1<ex>www.google.com</ex></ph> is secure.
These three messages don't need to be changed.

Why did you change "encrypted" to "secure"?  "Secure"
implies the server's identity is also authenticated,
more than the SSL messages are authenticated.

http://codereview.chromium.org/3033001/diff/4001/5001#newcode5211
chrome/app/generated_resources.grd:5211: The connection is encrypted using <ph
name="CIPHER">$1<ex>AES_128</ex></ph>, with <ph name="MAC">$2<ex>SHA1</ex></ph>
for authentication and <ph name="KX">$3<ex>RSA</ex></ph> as the key exchange
mechanism.
Nit: authentication => message authentication

http://codereview.chromium.org/3033001/diff/4001/5001#newcode5213
chrome/app/generated_resources.grd:5213: <message
name="IDS_PAGE_INFO_SECURITY_TAB_FALLBACK_MESSAGE" desc="This message is
displayed when the first secure connection to a site failed and Chrome retried
with an older protocol.">
Nit: older protocol => older SSL protocol

is unmaintained => is not up to date?
                   is using very old software?

http://codereview.chromium.org/3033001/diff/4001/5002
File chrome/browser/page_info_model.cc (right):

http://codereview.chromium.org/3033001/diff/4001/5002#newcode150
chrome/browser/page_info_model.cc:150: uint16_t cipher_suite =
Question: are we supposed to use uint16_t instead of uint16
in new code?

Would be nice to provide a macro or inline function for the
shift and mask operation.

http://codereview.chromium.org/3033001/diff/4001/5002#newcode167
chrome/browser/page_info_model.cc:167: description += ASCIIToUTF16("\n\n");
Can we add "\n\n" here?  Are there some languages that
break lines in a different way?  Just wondering.

[agl, 2010-07-18 17:03:49]

http://codereview.chromium.org/3033001/diff/4001/5001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/3033001/diff/4001/5001#newcode5193
chrome/app/generated_resources.grd:5193: Your connection to <ph
name="DOMAIN">$1<ex>www.google.com</ex></ph> is secure.
On 2010/07/16 20:07:10, wtc wrote:
> These three messages don't need to be changed.
> 
> Why did you change "encrypted" to "secure"?  "Secure"
> implies the server's identity is also authenticated,
> more than the SSL messages are authenticated.

I changed these messages because the duplicate use of 'encryption' didn't read
quite right to me. I've reverted it, but see what you think of the new dialog
when you next do a build.

http://codereview.chromium.org/3033001/diff/4001/5001#newcode5211
chrome/app/generated_resources.grd:5211: The connection is encrypted using <ph
name="CIPHER">$1<ex>AES_128</ex></ph>, with <ph name="MAC">$2<ex>SHA1</ex></ph>
for authentication and <ph name="KX">$3<ex>RSA</ex></ph> as the key exchange
mechanism.
On 2010/07/16 20:07:10, wtc wrote:
> Nit: authentication => message authentication

Done.

http://codereview.chromium.org/3033001/diff/4001/5001#newcode5213
chrome/app/generated_resources.grd:5213: <message
name="IDS_PAGE_INFO_SECURITY_TAB_FALLBACK_MESSAGE" desc="This message is
displayed when the first secure connection to a site failed and Chrome retried
with an older protocol.">
On 2010/07/16 20:07:10, wtc wrote:
> Nit: older protocol => older SSL protocol
> 
> is unmaintained => is not up to date?
>                    is using very old software?

Done.

http://codereview.chromium.org/3033001/diff/4001/5002
File chrome/browser/page_info_model.cc (right):

http://codereview.chromium.org/3033001/diff/4001/5002#newcode150
chrome/browser/page_info_model.cc:150: uint16_t cipher_suite =
On 2010/07/16 20:07:10, wtc wrote:
> Question: are we supposed to use uint16_t instead of uint16
> in new code?

I haven't heard so. I tend to use _t because it's standard everywhere, but I've
changed this to the Chromium specific uint16 etc.

> Would be nice to provide a macro or inline function for the
> shift and mask operation.

Done.

http://codereview.chromium.org/3033001/diff/4001/5002#newcode167
chrome/browser/page_info_model.cc:167: description += ASCIIToUTF16("\n\n");
On 2010/07/16 20:07:10, wtc wrote:
> Can we add "\n\n" here?  Are there some languages that
> break lines in a different way?  Just wondering.

I wondered about that also, but I believe that we're doing it anyway when
building the dialog; the translated strings are just packed into a vbox.