Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5998)

Unified Diff: chrome/test/testing_pref_service.cc

Issue 3032058: Move creation of the PrefStores into the PrefValueStore, to reduce the knowle... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Comment-only changes Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/pref_value_store.cc ('K') | « chrome/test/testing_pref_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/testing_pref_service.cc
===================================================================
--- chrome/test/testing_pref_service.cc (revision 55061)
+++ chrome/test/testing_pref_service.cc (working copy)
@@ -7,8 +7,20 @@
#include "chrome/browser/dummy_pref_store.h"
#include "chrome/browser/pref_value_store.h"
+TestingPrefService::TestingPrefValueStore::TestingPrefValueStore(
+ PrefStore* managed_prefs,
+ PrefStore* extension_prefs,
+ PrefStore* command_line_prefs,
+ PrefStore* user_prefs,
+ PrefStore* recommended_prefs)
+ : PrefValueStore(managed_prefs, extension_prefs, command_line_prefs,
+ user_prefs, recommended_prefs) {
+}
+
+// TODO(pamg): Instantiate no PrefStores by default. Allow callers to specify
+// which they want, and expand usage of this class to more unit tests.
TestingPrefService::TestingPrefService()
- : PrefService(new PrefValueStore(
+ : PrefService(new TestingPrefValueStore(
managed_prefs_ = new DummyPrefStore(),
NULL,
NULL,
Property changes on: chrome\test\testing_pref_service.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« chrome/browser/pref_value_store.cc ('K') | « chrome/test/testing_pref_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698