Move creation of the PrefStores into the PrefValueStore, to reduce the knowle...

chrome/test/testing_pref_service.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/testing_pref_service.h"
 
 #include "chrome/browser/dummy_pref_store.h"
 #include "chrome/browser/pref_value_store.h"
 
+TestingPrefService::TestingPrefValueStore::TestingPrefValueStore(
+    PrefStore* managed_prefs,
+    PrefStore* extension_prefs,
+    PrefStore* command_line_prefs,
+    PrefStore* user_prefs,
+    PrefStore* recommended_prefs)
+    : PrefValueStore(managed_prefs, extension_prefs, command_line_prefs,
+      user_prefs, recommended_prefs) {
+}
+
+// TODO(pamg): Instantiate no PrefStores by default. Allow callers to specify
+// which they want, and expand usage of this class to more unit tests.
 TestingPrefService::TestingPrefService()
-    : PrefService(new PrefValueStore(
+    : PrefService(new TestingPrefValueStore(
           managed_prefs_ = new DummyPrefStore(),
           NULL,
           NULL,
           user_prefs_ = new DummyPrefStore(),
           NULL)) {
 }
 
 const Value* TestingPrefService::GetManagedPref(const wchar_t* path) {
   return GetPref(managed_prefs_, path);
 }
@@ skipping 29 matching lines @@
                                  Value* value) {
   pref_store->prefs()->Set(path, value);
   FireObservers(path);
 }
 
 void TestingPrefService::RemovePref(PrefStore* pref_store,
                                     const wchar_t* path) {
   pref_store->prefs()->Remove(path, NULL);
   FireObservers(path);
 }