Issue 3032035: Re-land 53849 (Revert 53857) - Implement most of the startup page controls in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3032035: Re-land 53849 (Revert 53857) - Implement most of the startup page controls in... (Closed)

Created:
10 years, 4 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Re-land 53849 (Revert 53857) - Implement most of the startup page controls in DOMUI prefs Hooks up display of startup pages, removal of pages, and setting the startup pages to the currently open tabs. Uses a select for now, but will eventually be replaced with a List so the favicons can be displayed. BUG=48713 TEST=Startup pages can be viewed, removed, and set to current in DOMUI prefs. Review URL: http://codereview.chromium.org/3046025 TBR=stuartmorgan@chromium.org Review URL: http://codereview.chromium.org/3058018 TBR=stuartmorgan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54031

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+198 lines, -19 lines)			Patch
M	chrome/browser/custom_home_pages_table_model.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/browser_options_handler.h	View	4 chunks	+31 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/browser_options_handler.cc	View	3 chunks	+97 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.js	View	4 chunks	+64 lines, -7 lines	0 comments	Download

Total messages: 1 (0 generated)