chrome/browser/custom_home_pages_table_model.cc - Issue 3032035: Re-land 53849 (Revert 53857) - Implement most of the startup page controls in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_home_pages_table_model.cc

Issue 3032035: Re-land 53849 (Revert 53857) - Implement most of the startup page controls in... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/custom_home_pages_table_model.cc

===================================================================

--- chrome/browser/custom_home_pages_table_model.cc (revision 54029)

+++ chrome/browser/custom_home_pages_table_model.cc (working copy)

@@ -14,6 +14,7 @@

#include "chrome/browser/profile.h"

#include "chrome/browser/tab_contents/tab_contents.h"

#include "chrome/common/pref_names.h"

+#include "chrome/common/url_constants.h"

#include "gfx/codec/png_codec.h"

#include "grit/app_resources.h"

#include "grit/generated_resources.h"

@@ -83,7 +84,9 @@

for (int tab_index = 0; tab_index < browser->tab_count(); ++tab_index) {

const GURL url = browser->GetTabContentsAt(tab_index)->GetURL();

- if (!url.is_empty())

+ if (!url.is_empty() &&

+ !(url.SchemeIs(chrome::kChromeUIScheme) &&

+ url.host() == chrome::kChromeUIOptionsHost))

Add(add_index++, url);

}

« no previous file with comments | « no previous file | chrome/browser/dom_ui/browser_options_handler.h » ('j') | no next file with comments »