Add undeclared virtual destructors part 2...

Add undeclared virtual destructors part 2

Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.

r=jar 
BUG=47469
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53831

[ziadh, 2010-07-26 21:39:30]

Hi jar,

Please let me know what you think.

[jar (doing other things), 2010-07-26 22:03:10]

Please add a line in the CL description above the r=jar:
BUG=47469

You should also remove all the files in the CL that you don't have changes for.

One suggestion below.

http://codereview.chromium.org/3032024/diff/30002/39006
File chrome/installer/util/html_dialog.h (right):

http://codereview.chromium.org/3032024/diff/30002/39006#newcode61
chrome/installer/util/html_dialog.h:61: friend class EulaHTMLDialog;
It is probably better to leave the descructor as public (which was the implicit
prior state) than to create a friend class (which grants access to all
internals, and makes code reading harder, with isolation less clear.)

Alternatively, if EulaHTMLDialog is actually a derived class, you shouldn't need
this friendship.

[ziadh, 2010-07-26 22:22:02]

http://codereview.chromium.org/3032024/diff/30002/39006
File chrome/installer/util/html_dialog.h (right):

http://codereview.chromium.org/3032024/diff/30002/39006#newcode61
chrome/installer/util/html_dialog.h:61: friend class EulaHTMLDialog;
On 2010/07/26 22:03:10, jar wrote:
> It is probably better to leave the descructor as public (which was the
implicit
> prior state) than to create a friend class (which grants access to all
> internals, and makes code reading harder, with isolation less clear.)
> 
> Alternatively, if EulaHTMLDialog is actually a derived class, you shouldn't
need
> this friendship.

Done.

[jar (doing other things), 2010-07-26 22:24:45]

LGTM