Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Unified Diff: chrome/installer/util/html_dialog.h

Issue 3032024: Add undeclared virtual destructors part 2... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/sandbox_mac_unittest_helper.h ('k') | chrome/renderer/pepper_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/html_dialog.h
===================================================================
--- chrome/installer/util/html_dialog.h (revision 53376)
+++ chrome/installer/util/html_dialog.h (working copy)
@@ -38,8 +38,13 @@
// The native window has been created and is about to be visible. Use it
// to customize the native |window| appearance.
virtual void OnBeforeDisplay(void* window) = 0;
+
+ protected:
+ virtual ~CustomizationCallback() {}
};
+ virtual ~HTMLDialog() {}
+
// Shows the HTML in a modal dialog. The buttons and other UI are also done
// in HTML so each native implementation needs to map the user action into
// one of the 6 possible results of DialogResult. Important, call this
@@ -50,7 +55,6 @@
// If the result of ShowModal() was EXTRA, the information is available
// as a string using this method.
virtual std::wstring GetExtraResult() = 0;
-
};
// Factory method for the native HTML Dialog. When done with the object use
« no previous file with comments | « chrome/common/sandbox_mac_unittest_helper.h ('k') | chrome/renderer/pepper_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698