Need $ on same line to not eval hash as command in bash

cros_mark_all_as_stable

Index: cros_mark_all_as_stable
diff --git a/cros_mark_all_as_stable b/cros_mark_all_as_stable
index 3d7967bc2c4ed6bae2d5089f89ef67204144f443..562d6110140735ed7e8abba88b13b471a0d5879a 100755
--- a/cros_mark_all_as_stable
+++ b/cros_mark_all_as_stable
@@ -47,8 +47,8 @@ for package in ${PACKAGES}; do
   eval $(${EBUILDCMD} ${ebuild_path} info) &> /dev/null || continue
   head_commit=$( cd "${CROS_WORKON_SRCDIR}" &&\
     bash -c "${GRAB_HEAD_COMMIT_CMD}" ) || continue
-  egit_commit=\
-    $(eval echo $(grep CROS_WORKON_COMMIT ${ebuild_path} | cut -f 2 -d '=')) ||\
+  egit_commit=$(\
+    eval echo $(grep CROS_WORKON_COMMIT ${ebuild_path} | cut -f 2 -d '=')) ||\

[Christopher Covington, 2010/07/26 16:36:24]

Too late now, but just a thought for the record. This has a pretty noisy
failure:

$ egit_commit=$(eval echo $(grep CROS_WORKON_COMMIT mm-core-oss-9999.ebuild |
cut -f 2 -d '=')) || echo "No CROS_WORKON_COMMIT found in
mm-core-oss-9999.ebuild" 
bash: eval: line 1: unexpected EOF while looking for matching `}'
bash: eval: line 2: syntax error: unexpected end of file
No CROS_WORKON_COMMIT found in mm-core-oss-9999.ebuild

Because of a line like this:
EGIT_BRANCH=${EGIT_BRANCH:="${CROS_WORKON_COMMIT}"}

Something along the lines of the following might fail a little more gracefully.
egit_commit=$(sed -nr 's/CROS_WORKON_COMMIT=("[a-z0-9]{40}")/\1/p'
"${ebuild_path}")
[ -z "${egit_commit}" ] && echo "No CROS_WORKON_COMMIT found in ${ebuild_path}"

I've only been testing this snippet so I don't know if the quotes should be a
part of the string or not. Looks like the grep and cut line includes them
though.

       echo "No CROS_WORKON_COMMIT found in ${ebuild_path}"
   if [[ ${head_commit} != ${egit_commit} ]] && \
     [ -n "${head_commit}" ]; then
@@ -56,6 +56,8 @@ for package in ${PACKAGES}; do
       "HEAD ${head_commit} != CROS_WORKON_COMMIT ${egit_commit} for ${package}"
     PACKAGE_LIST="${PACKAGE_LIST} ${package}"
     COMMIT_ID_LIST="${COMMIT_ID_LIST} ${head_commit}"
+  elif [[ ${head_commit}  = ${egit_commit} ]]; then
+    info "Commit id's match for ${package}"
   fi
 done