Need $ on same line to not eval hash as command in bash

cros_mark_all_as_stable

 #!/bin/bash
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Wrapper scripts around cros_mark_as_stable that marks all packages as stable
 # that have CROS_WORKON_COMMIT that is different than the current HEAD commit
 # of the corresponding git repository.
 
@@ skipping 29 matching lines @@
 
 # For each package, compares the head commit id to the commit id in the ebuild.
 # If they do not match, add the package and its commit id into ${PACKAGE_LIST}
 # and ${COMMIT_ID_LIST}
 for package in ${PACKAGES}; do
   ebuild_path=$(${EQUERYCMD} which ${package}) || continue
   # Sets ${CROS_WORKON_SRCDIR} from the ebuild.
   eval $(${EBUILDCMD} ${ebuild_path} info) &> /dev/null || continue
   head_commit=$( cd "${CROS_WORKON_SRCDIR}" &&\
     bash -c "${GRAB_HEAD_COMMIT_CMD}" ) || continue
-  egit_commit=\
-    $(eval echo $(grep CROS_WORKON_COMMIT ${ebuild_path} | cut -f 2 -d '=')) ||\
+  egit_commit=$(\
+    eval echo $(grep CROS_WORKON_COMMIT ${ebuild_path} | cut -f 2 -d '=')) ||\

[Christopher Covington, 2010/07/26 16:36:24]

Too late now, but just a thought for the record. This has a pretty noisy
failure:

$ egit_commit=$(eval echo $(grep CROS_WORKON_COMMIT mm-core-oss-9999.ebuild |
cut -f 2 -d '=')) || echo "No CROS_WORKON_COMMIT found in
mm-core-oss-9999.ebuild" 
bash: eval: line 1: unexpected EOF while looking for matching `}'
bash: eval: line 2: syntax error: unexpected end of file
No CROS_WORKON_COMMIT found in mm-core-oss-9999.ebuild

Because of a line like this:
EGIT_BRANCH=${EGIT_BRANCH:="${CROS_WORKON_COMMIT}"}

Something along the lines of the following might fail a little more gracefully.
egit_commit=$(sed -nr 's/CROS_WORKON_COMMIT=("[a-z0-9]{40}")/\1/p'
"${ebuild_path}")
[ -z "${egit_commit}" ] && echo "No CROS_WORKON_COMMIT found in ${ebuild_path}"

I've only been testing this snippet so I don't know if the quotes should be a
part of the string or not. Looks like the grep and cut line includes them
though.

       echo "No CROS_WORKON_COMMIT found in ${ebuild_path}"
   if [[ ${head_commit} != ${egit_commit} ]] && \
     [ -n "${head_commit}" ]; then
     info\
       "HEAD ${head_commit} != CROS_WORKON_COMMIT ${egit_commit} for ${package}"
     PACKAGE_LIST="${PACKAGE_LIST} ${package}"
     COMMIT_ID_LIST="${COMMIT_ID_LIST} ${head_commit}"
+  elif [[ ${head_commit}  = ${egit_commit} ]]; then
+    info "Commit id's match for ${package}"
   fi
 done
 
 info "Candidate package list ${PACKAGE_LIST}"
 info "With commit id list ${COMMIT_ID_LIST}"
 
 ./cros_mark_as_stable --board ${FLAGS_board} -p "${PACKAGE_LIST}" \
   -i "${COMMIT_ID_LIST}" commit  || \
     die "Could not mark all packages as stable"