Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: base/file_util_win.cc

Issue 3031041: Fix incorect tests against INVALID_FILE_HANDLE, as pointed out by cpu on chrome-team. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Rebase for checkin. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_win.cc
diff --git a/base/file_util_win.cc b/base/file_util_win.cc
index 33491eddcc40c81e2834bc9bf3a463bfa32ae6d0..aa965bf0982d39b3c096fbda0b8d11ae2ed03cd3 100644
--- a/base/file_util_win.cc
+++ b/base/file_util_win.cc
@@ -976,7 +976,7 @@ bool NormalizeFilePath(const FilePath& path, FilePath* real_path) {
OPEN_EXISTING,
FILE_ATTRIBUTE_NORMAL,
NULL));
- if (path_handle == INVALID_HANDLE_VALUE)
+ if (!path_handle.IsValid())
return false;
// In Vista, GetFinalPathNameByHandle() would give us the real path
@@ -1002,7 +1002,7 @@ bool NormalizeFilePath(const FilePath& path, FilePath* real_path) {
1, // Just one byte. No need to look at the data.
NULL));
- if (file_map_handle == INVALID_HANDLE_VALUE)
+ if (!file_map_handle.IsValid())
return false;
// Use a view of the file to get the path to the file.
« no previous file with comments | « base/file_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698