Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2889)

Unified Diff: base/file_util_unittest.cc

Issue 3031041: Fix incorect tests against INVALID_FILE_HANDLE, as pointed out by cpu on chrome-team. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Rebase for checkin. Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/file_util_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_unittest.cc
diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc
index 4a1417aea9a608b64e971638c48e1fd5dbdaca9a..7ee762852e209f1c7c2b8497e37670ab6aca8bff 100644
--- a/base/file_util_unittest.cc
+++ b/base/file_util_unittest.cc
@@ -575,7 +575,7 @@ TEST_F(FileUtilTest, NormalizeFilePathReparsePoints) {
OPEN_EXISTING,
FILE_FLAG_BACKUP_SEMANTICS, // Needed to open a directory.
NULL));
- ASSERT_NE(INVALID_HANDLE_VALUE, reparse_to_sub_a.Get());
+ ASSERT_TRUE(reparse_to_sub_a.IsValid());
ASSERT_TRUE(SetReparsePoint(reparse_to_sub_a, sub_a));
FilePath to_base_b = base_b.Append(FPL("to_base_b"));
@@ -588,7 +588,7 @@ TEST_F(FileUtilTest, NormalizeFilePathReparsePoints) {
OPEN_EXISTING,
FILE_FLAG_BACKUP_SEMANTICS, // Needed to open a directory.
NULL));
- ASSERT_NE(INVALID_HANDLE_VALUE, reparse_to_base_b.Get());
+ ASSERT_TRUE(reparse_to_base_b.IsValid());
ASSERT_TRUE(SetReparsePoint(reparse_to_base_b, base_b));
FilePath to_sub_long = base_b.Append(FPL("to_sub_long"));
@@ -601,7 +601,7 @@ TEST_F(FileUtilTest, NormalizeFilePathReparsePoints) {
OPEN_EXISTING,
FILE_FLAG_BACKUP_SEMANTICS, // Needed to open a directory.
NULL));
- ASSERT_NE(INVALID_HANDLE_VALUE, reparse_to_sub_long.Get());
+ ASSERT_TRUE(reparse_to_sub_long.IsValid());
ASSERT_TRUE(SetReparsePoint(reparse_to_sub_long, sub_long));
// Normalize a junction free path: base_a\sub_a\file.txt .
« no previous file with comments | « no previous file | base/file_util_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698