Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/renderer/form_manager_unittest.cc

Issue 3029061: AutoFill: Remove one level of indirection when clearing a previewed form. (Closed)
Patch Set: Fix test. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/form_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/form_manager_unittest.cc
diff --git a/chrome/renderer/form_manager_unittest.cc b/chrome/renderer/form_manager_unittest.cc
index 48c80548770e335a05e78a222c73c50ac3137d55..a72b60187a14e4ac8f4b399d058090b26f5b2e41 100644
--- a/chrome/renderer/form_manager_unittest.cc
+++ b/chrome/renderer/form_manager_unittest.cc
@@ -2304,7 +2304,7 @@ TEST_F(FormManagerTest, ClearFormWithNode) {
0)));
}
-TEST_F(FormManagerTest, ClearPreviewedForm) {
+TEST_F(FormManagerTest, ClearPreviewedFormWithNode) {
LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
" <INPUT type=\"text\" id=\"firstname\" value=\"Wyatt\"/>"
" <INPUT type=\"text\" id=\"lastname\"/>"
@@ -2339,7 +2339,7 @@ TEST_F(FormManagerTest, ClearPreviewedForm) {
email.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
// Clear the previewed fields.
- EXPECT_TRUE(form_manager.ClearPreviewedForm(forms[0]));
+ EXPECT_TRUE(form_manager.ClearPreviewedFormWithNode(firstname));
// Fields with non-empty values are not modified.
EXPECT_EQ(ASCIIToUTF16("Wyatt"), firstname.value());
« no previous file with comments | « chrome/renderer/form_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698