AutoFill: Remove one level of indirection when clearing a previewed form.

chrome/renderer/form_manager_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/renderer/form_manager.h"
 #include "chrome/test/render_view_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebDocument.h"
@@ skipping 2286 matching lines @@
                 ASCIIToUTF16("hidden"),
                 0)));
   EXPECT_TRUE(fields2[5].StrictlyEqualsHack(
       FormField(string16(),
                 string16(),
                 string16(),
                 ASCIIToUTF16("submit"),
                 0)));
 }
 
-TEST_F(FormManagerTest, ClearPreviewedForm) {
+TEST_F(FormManagerTest, ClearPreviewedFormWithNode) {
   LoadHTML("<FORM name=\"TestForm\" action=\"http://buh.com\" method=\"post\">"
            "  <INPUT type=\"text\" id=\"firstname\" value=\"Wyatt\"/>"
            "  <INPUT type=\"text\" id=\"lastname\"/>"
            "  <INPUT type=\"text\" id=\"email\"/>"
            "  <INPUT type=\"submit\" value=\"Send\"/>"
            "</FORM>");
 
   WebFrame* web_frame = GetMainFrame();
   ASSERT_NE(static_cast<WebFrame*>(NULL), web_frame);
 
@@ skipping 14 matching lines @@
   lastname.setAutofilled(true);
   WebInputElement email =
       web_frame->document().getElementById("email").to<WebInputElement>();
   email.setAutofilled(true);
 
   // Set the suggested values on two of the elements.
   lastname.setSuggestedValue(ASCIIToUTF16("Earp"));
   email.setSuggestedValue(ASCIIToUTF16("wyatt@earp.com"));
 
   // Clear the previewed fields.
-  EXPECT_TRUE(form_manager.ClearPreviewedForm(forms[0]));
+  EXPECT_TRUE(form_manager.ClearPreviewedFormWithNode(firstname));
 
   // Fields with non-empty values are not modified.
   EXPECT_EQ(ASCIIToUTF16("Wyatt"), firstname.value());
   EXPECT_TRUE(firstname.suggestedValue().isEmpty());
   EXPECT_TRUE(firstname.isAutofilled());
 
   // Verify the previewed fields are cleared.
   EXPECT_TRUE(lastname.value().isEmpty());
   EXPECT_TRUE(lastname.suggestedValue().isEmpty());
   EXPECT_FALSE(lastname.isAutofilled());
@@ skipping 93 matching lines @@
 
   WebElement e = web_frame->document().getElementById("firstname");
   WebFormControlElement firstname = e.to<WebFormControlElement>();
 
   // Hidden form control element should not have a label set.
   FormManager form_manager;
   EXPECT_EQ(string16(), form_manager.LabelForElement(firstname));
 }
 
 }  // namespace