Issue 3028030: Remove static caching of default favicon in CustomHomePagesTableModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3028030: Remove static caching of default favicon in CustomHomePagesTableModel (Closed)

Created:
10 years, 4 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

Remove static caching of default favicon in CustomHomePagesTableModel This fixes an assertion failure when trying to use this class on the Mac due to SkBitmap destruction happening during process exit handling. BUG=None TEST=Custom startup page list should still show default favicons. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54014

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -18 lines)			Patch
	M	chrome/browser/custom_home_pages_table_model.h	View		3 chunks	+2 lines, -3 lines	0 comments	Download
	M	chrome/browser/custom_home_pages_table_model.cc	View		3 chunks	+5 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

Can you think of any reason we would need to keep this code? It's not ...

10 years, 4 months ago (2010-07-27 23:42:07 UTC) #1

OK

Expand Messages | Collapse Messages