Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2926)

Unified Diff: chrome/browser/custom_home_pages_table_model.h

Issue 3028030: Remove static caching of default favicon in CustomHomePagesTableModel (Closed)
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/custom_home_pages_table_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/custom_home_pages_table_model.h
diff --git a/chrome/browser/custom_home_pages_table_model.h b/chrome/browser/custom_home_pages_table_model.h
index 0b095e49d41347cb5e320813f93a569e1f0ebcd3..4986ca02938f7c793cce9f8adbef8e0b8594ce25 100644
--- a/chrome/browser/custom_home_pages_table_model.h
+++ b/chrome/browser/custom_home_pages_table_model.h
@@ -10,6 +10,7 @@
#include <vector>
#include "app/table_model.h"
+#include "base/scoped_ptr.h"
#include "chrome/browser/history/history.h"
#include "chrome/browser/favicon_service.h"
#include "googleurl/src/gurl.h"
@@ -71,8 +72,6 @@ class CustomHomePagesTableModel : public TableModel {
FaviconService::Handle fav_icon_handle;
};
- static void InitClass();
-
// Loads the title and favicon for the specified entry.
void LoadTitleAndFavIcon(Entry* entry);
@@ -109,7 +108,7 @@ class CustomHomePagesTableModel : public TableModel {
std::vector<Entry> entries_;
// Default icon to show when one can't be found for the URL.
- static SkBitmap default_favicon_;
+ SkBitmap* default_favicon_;
// Profile used to load titles and icons.
Profile* profile_;
« no previous file with comments | « no previous file | chrome/browser/custom_home_pages_table_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698