Issue 3027023: When the kChromeUIScheme was made savable, it also broke the disabling of the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3027023: When the kChromeUIScheme was made savable, it also broke the disabling of the (Closed)

Created:
10 years, 5 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
zel

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

When the kChromeUIScheme was made savable, it also broke the disabling of the encoding menu on those pages. BUG=48157 TEST=On the NTP, Wrench menu --> Tools --> Encoding is disabled. On normal web pages, it isn't. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53785

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

This regressed from your CL: http://codereview.chromium.org/2880009

10 years, 5 months ago (2010-07-26 15:35:45 UTC) #1

LGTM

Expand Messages | Collapse Messages