Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 3027023: When the kChromeUIScheme was made savable, it also broke the disabling of the (Closed)

Created:
10 years, 5 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
zel
CC:
chromium-reviews, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

When the kChromeUIScheme was made savable, it also broke the disabling of the encoding menu on those pages. BUG=48157 TEST=On the NTP, Wrench menu --> Tools --> Encoding is disabled. On normal web pages, it isn't. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/browser.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
This regressed from your CL: http://codereview.chromium.org/2880009
10 years, 5 months ago (2010-07-26 15:35:45 UTC) #1
zel
10 years, 5 months ago (2010-07-26 17:00:20 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698