Issue 2880009: Made chrome: schema pages savable. Reenabled print context menu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2880009: Made chrome: schema pages savable. Reenabled print context menu... (Closed)

Created:
10 years, 5 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews, Paul Godavari, brettw-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Made chrome: schema savable. Reenabled print context menu that was previously disabled in ChromeOS. BUG=chrome-os:4073 TEST=open about:system, right mouse click and pick Save As menu item Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51998

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/views/bug_report_view.cc	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/common/url_constants.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm http://codereview.chromium.org/2880009/diff/1/3 File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/2880009/diff/1/3#newcode818 chrome/browser/tab_contents/render_view_context_menu.cc:818: remove empty line

10 years, 5 months ago (2010-07-01 03:46:10 UTC) #2

zel

10 years, 5 months ago (2010-07-09 17:31:35 UTC) #3

http://codereview.chromium.org/2880009/diff/1/3
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/2880009/diff/1/3#newcode818
chrome/browser/tab_contents/render_view_context_menu.cc:818: 
On 2010/07/01 03:46:10, oshima wrote:
> remove empty line

Done.

Expand Messages | Collapse Messages