Issue 3027011: Do not directly manipulate global structs. Work on the local copy instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3027011: Do not directly manipulate global structs. Work on the local copy instead. (Closed)

Created:
10 years, 5 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Description

(In the right repository this time.) Do not directly manipulate global structs. Work on the local copy instead. In firmware-land, globals are a bad idea.

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -68 lines)			Patch
M	firmware/lib/tpm_lite/include/tlcl_structures.h	View		1 chunk	+34 lines, -34 lines	0 comments	Download
M	firmware/lib/tpm_lite/tlcl.c	View	1	4 chunks	+31 lines, -19 lines	0 comments	Download
M	firmware/version.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utility/Makefile	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	utility/tlcl_generator.c	View		11 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

10 years, 5 months ago (2010-07-20 02:02:31 UTC) #2

lgtm

http://codereview.chromium.org/3027011/diff/1/3
File firmware/lib/tpm_lite/tlcl.c (right):

http://codereview.chromium.org/3027011/diff/1/3#newcode110
firmware/lib/tpm_lite/tlcl.c:110: ToTpmUint32((uint8_t*)&cmd +
tpm_nv_definespace_cmd.index, index);
Could just use cmd.buffer instead of the ref+typecast.

Expand Messages | Collapse Messages