Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 3027011: Do not directly manipulate global structs. Work on the local copy instead. (Closed)

Created:
10 years, 5 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

(In the right repository this time.) Do not directly manipulate global structs. Work on the local copy instead. In firmware-land, globals are a bad idea.

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -68 lines) Patch
M firmware/lib/tpm_lite/include/tlcl_structures.h View 1 chunk +34 lines, -34 lines 0 comments Download
M firmware/lib/tpm_lite/tlcl.c View 1 4 chunks +31 lines, -19 lines 0 comments Download
M firmware/version.c View 1 1 chunk +1 line, -1 line 0 comments Download
M utility/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M utility/tlcl_generator.c View 11 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
10 years, 5 months ago (2010-07-19 23:35:32 UTC) #1
Randall Spangler
10 years, 5 months ago (2010-07-20 02:02:31 UTC) #2
lgtm

http://codereview.chromium.org/3027011/diff/1/3
File firmware/lib/tpm_lite/tlcl.c (right):

http://codereview.chromium.org/3027011/diff/1/3#newcode110
firmware/lib/tpm_lite/tlcl.c:110: ToTpmUint32((uint8_t*)&cmd +
tpm_nv_definespace_cmd.index, index);
Could just use cmd.buffer instead of the ref+typecast.

Powered by Google App Engine
This is Rietveld 408576698