Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: chrome/common/process_watcher_unittest.cc

Issue 3026055: Cleanup in base. This moves the implementation (and a bunch of header file... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/process_watcher.h" 5 #include "chrome/common/process_watcher.h"
6 6
7 #if defined(OS_POSIX) 7 #if defined(OS_POSIX)
8 #include <sys/wait.h> 8 #include <sys/wait.h>
9 9
10 #include "base/eintr_wrapper.h" 10 #include "base/eintr_wrapper.h"
11 #include "base/multiprocess_test.h"
12 #include "base/process_util.h" 11 #include "base/process_util.h"
12 #include "base/test/multiprocess_test.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "testing/multiprocess_func_list.h"
14 15
15 class ProcessWatcherTest : public MultiProcessTest { 16 class ProcessWatcherTest : public base::MultiProcessTest {
16 }; 17 };
17 18
18 namespace { 19 namespace {
19 20
20 bool IsProcessDead(base::ProcessHandle child) { 21 bool IsProcessDead(base::ProcessHandle child) {
21 // waitpid() will actually reap the process which is exactly NOT what we 22 // waitpid() will actually reap the process which is exactly NOT what we
22 // want to test for. The good thing is that if it can't find the process 23 // want to test for. The good thing is that if it can't find the process
23 // we'll get a nice value for errno which we can test for. 24 // we'll get a nice value for errno which we can test for.
24 const pid_t result = HANDLE_EINTR(waitpid(child, NULL, WNOHANG)); 25 const pid_t result = HANDLE_EINTR(waitpid(child, NULL, WNOHANG));
25 return result == -1 && errno == ECHILD; 26 return result == -1 && errno == ECHILD;
26 } 27 }
27 28
28 } // namespace 29 } // namespace
29 30
30 TEST_F(ProcessWatcherTest, DelayedTermination) { 31 TEST_F(ProcessWatcherTest, DelayedTermination) {
31 base::ProcessHandle child_process = 32 base::ProcessHandle child_process =
32 SpawnChild("process_watcher_test_never_die"); 33 SpawnChild("process_watcher_test_never_die", false);
33 ProcessWatcher::EnsureProcessTerminated(child_process); 34 ProcessWatcher::EnsureProcessTerminated(child_process);
34 base::WaitForSingleProcess(child_process, 5000); 35 base::WaitForSingleProcess(child_process, 5000);
35 36
36 // Check that process was really killed. 37 // Check that process was really killed.
37 EXPECT_TRUE(IsProcessDead(child_process)); 38 EXPECT_TRUE(IsProcessDead(child_process));
38 base::CloseProcessHandle(child_process); 39 base::CloseProcessHandle(child_process);
39 } 40 }
40 41
41 MULTIPROCESS_TEST_MAIN(process_watcher_test_never_die) { 42 MULTIPROCESS_TEST_MAIN(process_watcher_test_never_die) {
42 while (1) { 43 while (1) {
43 sleep(500); 44 sleep(500);
44 } 45 }
45 return 0; 46 return 0;
46 } 47 }
47 48
48 TEST_F(ProcessWatcherTest, ImmediateTermination) { 49 TEST_F(ProcessWatcherTest, ImmediateTermination) {
49 base::ProcessHandle child_process = 50 base::ProcessHandle child_process =
50 SpawnChild("process_watcher_test_die_immediately"); 51 SpawnChild("process_watcher_test_die_immediately", false);
51 // Give it time to die. 52 // Give it time to die.
52 sleep(2); 53 sleep(2);
53 ProcessWatcher::EnsureProcessTerminated(child_process); 54 ProcessWatcher::EnsureProcessTerminated(child_process);
54 55
55 // Check that process was really killed. 56 // Check that process was really killed.
56 EXPECT_TRUE(IsProcessDead(child_process)); 57 EXPECT_TRUE(IsProcessDead(child_process));
57 base::CloseProcessHandle(child_process); 58 base::CloseProcessHandle(child_process);
58 } 59 }
59 60
60 MULTIPROCESS_TEST_MAIN(process_watcher_test_die_immediately) { 61 MULTIPROCESS_TEST_MAIN(process_watcher_test_die_immediately) {
61 return 0; 62 return 0;
62 } 63 }
63 64
64 #endif // OS_POSIX 65 #endif // OS_POSIX
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698