FBTF: Allow forward declaration of classes passed to sync IPC messages.

FBTF: Allow forward declaration of classes passed to sync IPC messages.

This is a continuation of r55259, where we convert the remaining IPC messages
to the new system. At this point, all the messages should be able to accept
forward declared classes/structs as parameters.

BUG=51411
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55735

[Elliot Glaysher, 2010-08-06 20:33:42]

This is part two, where I change all the sync messages. Also includes a few
conversions to forward declared headers to show that it's possible with types
that use sync messages.

Most of part3 is already under way with the mass removal of headers. I'll send
that out for review as soon as I commit this part.

[Matt Perry, 2010-08-06 20:53:02]

Looking good.

http://codereview.chromium.org/3018045/diff/4001/5002
File chrome/common/render_messages.cc (right):

http://codereview.chromium.org/3018045/diff/4001/5002#newcode14
chrome/common/render_messages.cc:14: namespace IPC {
Does this need to come before the #include of the ipc_message_impl header?

http://codereview.chromium.org/3018045/diff/4001/5002#newcode73
chrome/common/render_messages.cc:73: #include "webkit/glue/webcursor.h"
duplicate #include

http://codereview.chromium.org/3018045/diff/4001/5008
File ipc/ipc_message_impl_macros.h (right):

http://codereview.chromium.org/3018045/diff/4001/5008#newcode251
ipc/ipc_message_impl_macros.h:251: void msg_class::Log(const Message* msg,
std::wstring* l) {            \
All the Log functions are identical. Can we extract the definitions to a macro?
Or maybe a common template function that each definition calls? (defined in this
header)

http://codereview.chromium.org/3018045/diff/4001/5010
File ipc/ipc_message_utils.h (right):

http://codereview.chromium.org/3018045/diff/4001/5010#newcode1179
ipc/ipc_message_utils.h:1179: inline void ConectMessageAndReply(const Message*
msg, Message* reply) {
Connect*

[Elliot Glaysher, 2010-08-06 21:14:33]

Done. TAL?

[Matt Perry, 2010-08-06 21:18:49]

LGTM