Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Side by Side Diff: ipc/ipc_message_utils_impl.h

Issue 3018045: FBTF: Allow forward declaration of classes passed to sync IPC messages. (Closed)
Patch Set: Fix linkage problems with previous patch. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_message_utils.h ('k') | ipc/ipc_sync_channel_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file contains templates forward declared (but not defined) in 5 // This file contains templates forward declared (but not defined) in
6 // ipc_message_utils.h so that they are only instantiated in certain files, 6 // ipc_message_utils.h so that they are only instantiated in certain files,
7 // notably ipc_message_impl_macros.h and a few IPC unit tests. 7 // notably ipc_message_impl_macros.h and a few IPC unit tests.
8 8
9 #ifndef IPC_IPC_MESSAGE_UTILS_IMPL_H_ 9 #ifndef IPC_IPC_MESSAGE_UTILS_IMPL_H_
10 #define IPC_IPC_MESSAGE_UTILS_IMPL_H_ 10 #define IPC_IPC_MESSAGE_UTILS_IMPL_H_
11 11
12 namespace IPC { 12 namespace IPC {
13 13
14 template <class ParamType> 14 template <class ParamType>
15 MessageWithTuple<ParamType>::MessageWithTuple( 15 MessageWithTuple<ParamType>::MessageWithTuple(
16 int32 routing_id, uint32 type, const RefParam& p) 16 int32 routing_id, uint32 type, const RefParam& p)
17 : Message(routing_id, type, PRIORITY_NORMAL) { 17 : Message(routing_id, type, PRIORITY_NORMAL) {
18 WriteParam(this, p); 18 WriteParam(this, p);
19 } 19 }
20 20
21 template <class ParamType> 21 // TODO(erg): Migrate the Read() methods here when I figure out the linkage
22 bool MessageWithTuple<ParamType>::Read(const Message* msg, Param* p) { 22 // problems that broke the release build.
23 void* iter = NULL;
24 if (ReadParam(msg, &iter, p))
25 return true;
26 NOTREACHED() << "Error deserializing message " << msg->type();
27 return false;
28 }
29 23
30 // We can't migrate the template for Log() to MessageWithTuple, because each 24 // We can't migrate the template for Log() to MessageWithTuple, because each
31 // subclass needs to have Log() to call Read(), which instantiates the above 25 // subclass needs to have Log() to call Read(), which instantiates the above
32 // template. 26 // template.
33 27
28 template <class SendParamType, class ReplyParamType>
29 MessageWithReply<SendParamType, ReplyParamType>::MessageWithReply(
30 int32 routing_id, uint32 type,
31 const RefSendParam& send,
32 const ReplyParam& reply)
33 : SyncMessage(routing_id, type, PRIORITY_NORMAL,
34 new ParamDeserializer<ReplyParam>(reply)) {
35 WriteParam(this, send);
36 }
37
38 // TODO(erg): Migrate ReadSendParam()/ReadReplyParam() here when we can force
39 // the visibility/linkage.
40
34 } // namespace IPC 41 } // namespace IPC
35 42
36 #endif // IPC_IPC_MESSAGE_UTILS_IMPL_H_ 43 #endif // IPC_IPC_MESSAGE_UTILS_IMPL_H_
OLDNEW
« no previous file with comments | « ipc/ipc_message_utils.h ('k') | ipc/ipc_sync_channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698