Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 3017056: Update the names of some parameters passed to contextMenu onclick handlers.... (Closed)

Created:
10 years, 4 months ago by asargent_no_longer_on_chrome
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Update the names of some parameters passed to contextMenu onclick handlers. This changes the mediaType parameter values to be lowercase (eg "audio" instead of "AUDIO"), and changes mainFrameUrl to be pageUrl as the design doc had intended. BUG=49725 TEST=In onclick handlers, values for mediaType should be lowercase and there should be a pageUrl property matching the url of the page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54999

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/extensions/extension_menu_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_menu_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
asargent_no_longer_on_chrome
10 years, 4 months ago (2010-08-04 22:23:11 UTC) #1
Aaron Boodman
10 years, 4 months ago (2010-08-04 22:24:42 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698