chrome/browser/extensions/extension_menu_manager_unittest.cc - Issue 3017056: Update the names of some parameters passed to contextMenu onclick handlers....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_menu_manager_unittest.cc

Issue 3017056: Update the names of some parameters passed to contextMenu onclick handlers.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_menu_manager_unittest.cc

===================================================================

--- chrome/browser/extensions/extension_menu_manager_unittest.cc (revision 54936)

+++ chrome/browser/extensions/extension_menu_manager_unittest.cc (working copy)

@@ -448,10 +448,10 @@

std::string tmp;

ASSERT_TRUE(info->GetString(L"mediaType", &tmp));

- ASSERT_EQ("IMAGE", tmp);

+ ASSERT_EQ("image", tmp);

ASSERT_TRUE(info->GetString(L"srcUrl", &tmp));

ASSERT_EQ(params.src_url.spec(), tmp);

- ASSERT_TRUE(info->GetString(L"mainFrameUrl", &tmp));

+ ASSERT_TRUE(info->GetString(L"pageUrl", &tmp));

ASSERT_EQ(params.page_url.spec(), tmp);

std::wstring wide_tmp;

« no previous file with comments | « chrome/browser/extensions/extension_menu_manager.cc ('k') | no next file » | no next file with comments »