Issue 3015055: Enable better NVDA support for custom menus....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3015055: Enable better NVDA support for custom menus.... (Closed)

Created:
10 years, 4 months ago by Chris Guillory

Modified:
9 years, 7 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, ben+cc_chromium.org, David Tseng

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Enable better NVDA support for custom menus. - Send the popupmenu events on the MenuScrollViewContainer since it is the View with the ROLE_MENUPOPUP role. - Return AccessibilityTypes::STATE_FOCUSED for MenuScrollViewContainer since it's not focused by MenuHostWin::ShowMenuHost. NVDA won't process children menu item's focus events unless a parent claims to have focus. TEST=The wrench menu and it's menu items are read aloud when using NVDA. BUG=49360 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55163

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -12 lines)			Patch
M	chrome/browser/views/wrench_menu.cc	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	views/accessibility/accessibility_types.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	views/accessibility/view_accessibility.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View	4 chunks	+1 line, -10 lines	0 comments	Download
M	views/controls/menu/menu_scroll_view_container.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	views/controls/menu/menu_scroll_view_container.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	views/controls/menu/submenu_view.cc	View	4 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks for figuring out this fix!

Expand Messages | Collapse Messages