Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3913)

Unified Diff: chrome/browser/views/wrench_menu.cc

Issue 3015055: Enable better NVDA support for custom menus.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/accessibility/accessibility_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/wrench_menu.cc
===================================================================
--- chrome/browser/views/wrench_menu.cc (revision 54772)
+++ chrome/browser/views/wrench_menu.cc (working copy)
@@ -22,6 +22,7 @@
#include "gfx/canvas.h"
#include "gfx/canvas_skia.h"
#include "gfx/skia_util.h"
+#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
#include "third_party/skia/include/core/SkPaint.h"
@@ -477,7 +478,7 @@
}
double GetZoom(bool* enable_increment, bool* enable_decrement) {
- // TODO: move this somewhere it can be shared.
+ // TODO(sky): move this somewhere it can be shared.
TabContents* selected_tab = menu_->browser_->GetSelectedTabContents();
*enable_decrement = *enable_increment = false;
if (!selected_tab)
@@ -557,6 +558,7 @@
void WrenchMenu::Init(menus::MenuModel* model) {
DCHECK(!root_.get());
root_.reset(new MenuItemView(this));
+ root_->SetAccessibleName(l10n_util::GetString(IDS_ACCNAME_APP));
root_->set_has_icons(true); // We have checks, radios and icons, set this
// so we get the taller menu style.
int next_id = 1;
« no previous file with comments | « no previous file | views/accessibility/accessibility_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698