Issue 3013043: AutoFill: Remove a static string16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3013043: AutoFill: Remove a static string16. (Closed)

Created:
10 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, ben+cc_chromium.org

Visibility:
Public.

Description

AutoFill: Remove a static string16. BUG=50669 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54176

Patch Set 2 : One line. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	M	chrome/browser/autofill/autofill_manager.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/autofill/credit_card.cc	View	1	3 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dhollowa

LGTM. http://codereview.chromium.org/3013043/diff/1/3 File chrome/browser/autofill/credit_card.cc (right): http://codereview.chromium.org/3013043/diff/1/3#newcode30 chrome/browser/autofill/credit_card.cc:30: arraysize(kAutoFillCreditCardTypes); Would this fit on one line?

10 years, 4 months ago (2010-07-29 20:12:02 UTC) #2

James Hawkins

10 years, 4 months ago (2010-07-29 20:12:54 UTC) #3

http://codereview.chromium.org/3013043/diff/1/3
File chrome/browser/autofill/credit_card.cc (right):

http://codereview.chromium.org/3013043/diff/1/3#newcode30
chrome/browser/autofill/credit_card.cc:30: arraysize(kAutoFillCreditCardTypes);
On 2010/07/29 20:12:02, dhollowa wrote:
> Would this fit on one line?

It does now, thanks.

Expand Messages | Collapse Messages

Issue 3013043: AutoFill: Remove a static string16. (Closed)

Description

Patch Set 1 #

Patch Set 2 : One line. #

Messages