Add a check that weak object handle is not in NEAR_DEATH state after weak callback invocation.

Add a check that weak object handle is not in NEAR_DEATH state after weak callback invocation.

If object enters NEAR_DEATH state, it must be explicitly cleared and/or disposed, otherwise
it would retain JS object forever.  Note as well that parameter is reset to NULL on first
invocation so weak handle callback would be in hard situation.

Committed: http://code.google.com/p/v8/source/detail?r=5096

[antonm, 2010-07-19 12:39:17]

Mads and Misha,

may you have a look?

Misha, could you have a closer look at TokenEnumeration stuff?

tia,
anton.

[Mads Ager (chromium), 2010-07-19 13:04:49]

LGTM

http://codereview.chromium.org/3011009/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/3011009/diff/1/2#newcode140
include/v8.h:140: * This callback should either explicitly |Dispose| |object| if
V8 wrapper
|Dispose| |object| -> invoke Dispose on |object|?

|MakeWeak| -> MakeWeak?

http://codereview.chromium.org/3011009/diff/1/3
File src/global-handles.cc (right):

http://codereview.chromium.org/3011009/diff/1/3#newcode182
src/global-handles.cc:182: ASSERT(state_ != NEAR_DEATH);  // Absense of explicit
cleanup or revival
Please move the comment to the line before the assert.

[antonm, 2010-07-19 13:24:24]

Thanks a lot, Mads.

http://codereview.chromium.org/3011009/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/3011009/diff/1/2#newcode140
include/v8.h:140: * This callback should either explicitly |Dispose| |object| if
V8 wrapper
On 2010/07/19 13:04:49, Mads Ager wrote:
> |Dispose| |object| -> invoke Dispose on |object|?
> 
> |MakeWeak| -> MakeWeak?

Done.

http://codereview.chromium.org/3011009/diff/1/3
File src/global-handles.cc (right):

http://codereview.chromium.org/3011009/diff/1/3#newcode182
src/global-handles.cc:182: ASSERT(state_ != NEAR_DEATH);  // Absense of explicit
cleanup or revival
On 2010/07/19 13:04:49, Mads Ager wrote:
> Please move the comment to the line before the assert.

Done.

[mnaganov (inactive), 2010-07-19 13:50:46]

Great! Thanks, Anton!