Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 3011008: Don't crash if the translate server reports a language we don't know (Closed)

Created:
10 years, 5 months ago by Jay Civelli
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

When Chrome translates a page, the translate server might detect that the page is in a different language than the one Chrome detected. If that language is not in the list of languages that Chrome supports for translation, then we do not know what to show and we were crashing. This CL makes it so that we show an error infobar instead. Note that in the future we should improve the "after translate" infobar to support showing the original language as unknown. (http://crbug.com/9390) BUG=48918 TEST=Not sure how to test without changing the code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52876

Patch Set 1 #

Patch Set 2 : Adding bug reference #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_manager_unittest.cc View 1 2 5 chunks +38 lines, -7 lines 0 comments Download
M chrome/common/translate_errors.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jay Civelli
10 years, 5 months ago (2010-07-17 01:36:16 UTC) #1
sky
http://codereview.chromium.org/3011008/diff/2001/3001 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/3011008/diff/2001/3001#newcode7144 chrome/app/generated_resources.grd:7144: This page has been translated from an unknown language ...
10 years, 5 months ago (2010-07-17 17:08:05 UTC) #2
Jay Civelli
http://codereview.chromium.org/3011008/diff/2001/3001 File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/3011008/diff/2001/3001#newcode7144 chrome/app/generated_resources.grd:7144: This page has been translated from an unknown language ...
10 years, 5 months ago (2010-07-18 08:11:15 UTC) #3
sky
10 years, 5 months ago (2010-07-18 23:34:27 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698