Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/translate/translate_manager.cc

Issue 3011008: Don't crash if the translate server reports a language we don't know (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_infobar_delegate.cc ('k') | chrome/browser/translate/translate_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager.cc
===================================================================
--- chrome/browser/translate/translate_manager.cc (revision 52843)
+++ chrome/browser/translate/translate_manager.cc (working copy)
@@ -479,6 +479,14 @@
infobar = TranslateInfoBarDelegate::CreateErrorDelegate(
details->error_type, tab,
details->source_language, details->target_language);
+ } else if (!IsSupportedLanguage(details->source_language)) {
+ // TODO(jcivelli): http://crbug.com/9390 We should change the "after
+ // translate" infobar to support unknown as the original
+ // language.
+ UMA_HISTOGRAM_COUNTS("Translate.ServerReportedUnsupportedLanguage", 1);
+ infobar = TranslateInfoBarDelegate::CreateErrorDelegate(
+ TranslateErrors::UNSUPPORTED_LANGUAGE, tab,
+ details->source_language, details->target_language);
} else {
infobar = TranslateInfoBarDelegate::CreateDelegate(
TranslateInfoBarDelegate::kAfterTranslate, tab,
« no previous file with comments | « chrome/browser/translate/translate_infobar_delegate.cc ('k') | chrome/browser/translate/translate_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698