Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 3010060: Fix bug in binary operations code. When loading a 32-bit integer as a... (Closed)

Created:
10 years, 4 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in binary operations code. When loading a 32-bit integer as a 64-bit integer to the stack, the high and low parts of the 64-bit value were pushed in the wrong order. TBR=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=5216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
10 years, 4 months ago (2010-08-09 14:53:56 UTC) #1
Erik Corry
10 years, 4 months ago (2010-08-10 09:32:24 UTC) #2
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698